fix(FloatButton): BackTop attribute invalid #7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
搞混了一个点，inheritAttrs为false时，通过attrs是能够手动消费透传，而且wrapSSR下inheritAttrs需为false |
|
|
tangjinzhou
requested changes
Oct 16, 2023
components/float-button/BackTop.tsx
Outdated
| }; | ||
|
|
||
| const transitionProps = getTransitionProps('fade'); | ||
| return wrapSSR( | ||
| <Transition {...transitionProps}> | ||
| <FloatButton v-show={state.visible} {...floatButtonProps} ref={domRef}> | ||
| {{ | ||
| icon: () => <VerticalAlignTopOutlined />, | ||
| default: () => slots.default?.() || defaultElement, | ||
| icon: () => slots.default?.() || slots.icon?.() || <VerticalAlignTopOutlined />, |
There was a problem hiding this comment.
我发现 default 是没有用到的吧, 就去掉吧，留着以后万一要加点什么
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7008
将inheritAttrs删除是因为组件内有消费attrs，type从props中取则是被声明过的props无法从attribute中获取